Merged
Conversation
Owner
atorch
commented
Oct 11, 2025
atorch
commented
- Update targetSdkVersion to 35.
- Implement a modern, full-screen theme with a Toolbar.
- Refactor the sharing functionality to use Intent.createChooser.
- Update button styles for a consistent look and feel.
- Update the release date in all translations to October 2025.
- Fix an instrumented test that was failing due to the UI changes.
- Add generated files to .gitignore.
- Update targetSdkVersion to 35. - Implement a modern, full-screen theme with a Toolbar. - Refactor the sharing functionality to use Intent.createChooser. - Update button styles for a consistent look and feel. - Update the release date in all translations to October 2025. - Fix an instrumented test that was failing due to the UI changes. - Add generated files to .gitignore.
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR modernizes the app's theme and UI to use Material Components with a full-screen theme and Toolbar implementation, while updating the target SDK to 35 and release metadata to October 2025.
- Update theme to Material Components with NoActionBar and implement Toolbar across activities
- Refactor sharing functionality from ShareActionProvider to Intent.createChooser
- Update app release date to October 2025 across all translations and add release signing configuration
Reviewed Changes
Copilot reviewed 15 out of 16 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| app/src/main/res/values/styles.xml | Switch to Material Components theme with NoActionBar and add custom button styles |
| app/src/main/res/values/strings.xml | Update release date from March to October 2025 |
| app/src/main/res/values/colors.xml | Add grey color for button styling |
| app/src/main/res/values-es/strings.xml | Update Spanish translation release date to October 2025 |
| app/src/main/res/values-de/strings.xml | Update German translation release date to October 2025 |
| app/src/main/res/values-ar/strings.xml | Update Arabic translation release date to October 2025 |
| app/src/main/res/layout/fragment_solve_puzzle.xml | Apply new button styles to submit, hint, and Gemini hint buttons |
| app/src/main/res/layout/activity_solve_puzzle.xml | Add Toolbar with AppBarLayout to replace ActionBar |
| app/src/main/res/layout/activity_puzzle_selection.xml | Add Toolbar with AppBarLayout and apply button styles |
| app/src/main/java/atorch/statspuzzles/SolvePuzzle.java | Replace ShareActionProvider with Intent.createChooser and configure Toolbar |
| app/src/main/java/atorch/statspuzzles/PuzzleSelection.java | Configure Toolbar for the puzzle selection activity |
| app/src/main/AndroidManifest.xml | Update theme reference to use base AppTheme |
| app/src/androidTest/java/atorch/statspuzzles/PuzzleSelectionTest.java | Fix test to check for intro button text instead of app name |
| app/build.gradle | Update targetSdkVersion to 35 and add release signing configuration |
| README.md | Add documentation for generating and testing release App Bundles |
Comments suppressed due to low confidence (1)
app/src/main/res/layout/fragment_solve_puzzle.xml:1
- The
android:layout_marginTopandandroid:visibilityattributes were removed when applying the new style. This could affect the button's positioning and initial visibility state.
<ScrollView xmlns:android="http://schemas.android.com/apk/res/android"
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Contributor
There was a problem hiding this comment.
Pull Request Overview
Copilot reviewed 15 out of 16 changed files in this pull request and generated no new comments.
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.